From 394956aafd2d047a9cd2f26612a3e3a47b056876 Mon Sep 17 00:00:00 2001 From: Adam Perkowski Date: Sun, 2 Feb 2025 05:00:20 +0100 Subject: [PATCH 1/9] chore: remove redundant files (#995) ref https://github.com/ChrisTitusTech/linutil/security/dependabot --- .github/requirements.txt | 51 ---------------------------------------- 1 file changed, 51 deletions(-) delete mode 100644 .github/requirements.txt diff --git a/.github/requirements.txt b/.github/requirements.txt deleted file mode 100644 index 295ed680..00000000 --- a/.github/requirements.txt +++ /dev/null @@ -1,51 +0,0 @@ -Babel==2.15.0 -bracex==2.5 -cairocffi==1.7.1 -CairoSVG==2.7.1 -certifi==2024.7.4 -cffi==1.17.0 -charset-normalizer==3.3.2 -click==8.1.7 -colorama==0.4.6 -csscompressor==0.9.5 -cssselect2==0.7.0 -defusedxml==0.7.1 -ghp-import==2.1.0 -gitdb==4.0.11 -GitPython==3.1.43 -htmlmin2==0.1.13 -idna==3.7 -Jinja2==3.1.4 -jsmin==3.0.1 -Markdown==3.6 -MarkupSafe==2.1.5 -mergedeep==1.3.4 -mkdocs==1.6.0 -mkdocs-awesome-pages-plugin==2.9.3 -mkdocs-get-deps==0.2.0 -mkdocs-git-revision-date-localized-plugin==1.2.6 -mkdocs-material==9.5.31 -mkdocs-material-extensions==1.3.1 -mkdocs-minify-plugin==0.8.0 -natsort==8.4.0 -packaging==24.1 -paginate==0.5.6 -pathspec==0.12.1 -pillow==10.4.0 -platformdirs==4.2.2 -pycparser==2.22 -Pygments==2.18.0 -pymdown-extensions==10.9 -python-dateutil==2.9.0.post0 -pytz==2024.1 -PyYAML==6.0.2 -pyyaml_env_tag==0.1 -regex==2024.7.24 -requests==2.32.3 -six==1.16.0 -smmap==5.0.1 -tinycss2==1.3.0 -urllib3==2.2.2 -watchdog==4.0.1 -wcmatch==9.0 -webencodings==0.5.1 From 5f7de33bb66727c22de17799b506d1f4323f927e Mon Sep 17 00:00:00 2001 From: Adam Perkowski Date: Sun, 2 Feb 2025 05:03:24 +0100 Subject: [PATCH 2/9] refact: fix (almost) all shellcheck errors (#997) the only files i didn't fix: - core/tabs/utils/ssh.sh (ref #996) - core/tabs/system-setup/arch/server-setup.sh --- .../applications-setup/android-debloat.sh | 2 +- .../applications-setup/browsers/librewolf.sh | 4 +-- .../communication-apps/discord-setup.sh | 4 +-- .../communication-apps/signal-setup.sh | 4 +-- .../tabs/applications-setup/dwmtitus-setup.sh | 4 +-- .../applications-setup/linutil-installer.sh | 2 +- .../applications-setup/linutil-updater.sh | 2 +- core/tabs/system-setup/compile-setup.sh | 12 ++++---- core/tabs/system-setup/system-cleanup.sh | 2 +- core/tabs/utils/bluetooth-control.sh | 15 +++++----- core/tabs/utils/encrypt_decrypt_tool.sh | 24 +++++++-------- .../utils/monitor-control/set_brightness.sh | 4 +-- .../utils/monitor-control/set_resolutions.sh | 2 +- core/tabs/utils/ollama.sh | 5 ++-- core/tabs/utils/samba-ssh-setup.sh | 4 +-- core/tabs/utils/service-control.sh | 4 +-- core/tabs/utils/timeshift.sh | 6 +++- .../user-account-manager/add_to_group.sh | 4 +-- .../user-account-manager/change_password.sh | 4 +-- .../utils/user-account-manager/delete_user.sh | 4 +-- .../user-account-manager/remove_from_group.sh | 6 ++-- core/tabs/utils/utility_functions.sh | 1 + core/tabs/utils/wifi-control.sh | 30 +++++++++---------- 23 files changed, 77 insertions(+), 72 deletions(-) diff --git a/core/tabs/applications-setup/android-debloat.sh b/core/tabs/applications-setup/android-debloat.sh index 63258023..1db9328b 100644 --- a/core/tabs/applications-setup/android-debloat.sh +++ b/core/tabs/applications-setup/android-debloat.sh @@ -19,7 +19,7 @@ install_adb() { "$ESCALATION_TOOL" "$PACKAGER" add android-tools ;; *) - printf "%b\n" "${RED}Unsupported package manager: "$PACKAGER"${RC}" + printf "%b\n" "${RED}Unsupported package manager: $PACKAGER${RC}" exit 1 ;; esac diff --git a/core/tabs/applications-setup/browsers/librewolf.sh b/core/tabs/applications-setup/browsers/librewolf.sh index d8ed06b4..f6974502 100644 --- a/core/tabs/applications-setup/browsers/librewolf.sh +++ b/core/tabs/applications-setup/browsers/librewolf.sh @@ -8,7 +8,7 @@ installLibreWolf() { case "$PACKAGER" in apt-get|nala) "$ESCALATION_TOOL" "$PACKAGER" install -y gnupg lsb-release apt-transport-https ca-certificates - distro=`if echo " una bookworm vanessa focal jammy bullseye vera uma " | grep -q " $(lsb_release -sc) "; then lsb_release -sc; else echo focal; fi` + distro=$(if echo " una bookworm vanessa focal jammy bullseye vera uma " | grep -q "$(lsb_release -sc)"; then "$(lsb_release -sc)"; else echo 'focal'; fi) curl -fsSL https://deb.librewolf.net/keyring.gpg | "$ESCALATION_TOOL" gpg --dearmor -o /usr/share/keyrings/librewolf.gpg echo "Types: deb URIs: https://deb.librewolf.net @@ -49,4 +49,4 @@ Signed-By: /usr/share/keyrings/librewolf.gpg" | "$ESCALATION_TOOL" tee /etc/apt/ checkEnv checkEscalationTool checkAURHelper -installLibreWolf \ No newline at end of file +installLibreWolf diff --git a/core/tabs/applications-setup/communication-apps/discord-setup.sh b/core/tabs/applications-setup/communication-apps/discord-setup.sh index f96bd9f2..0843a373 100644 --- a/core/tabs/applications-setup/communication-apps/discord-setup.sh +++ b/core/tabs/applications-setup/communication-apps/discord-setup.sh @@ -17,7 +17,7 @@ installDiscord() { "$ESCALATION_TOOL" "$PACKAGER" -S --needed --noconfirm discord ;; dnf) - "$ESCALATION_TOOL" "$PACKAGER" install -y https://download1.rpmfusion.org/nonfree/fedora/rpmfusion-nonfree-release-$(rpm -E %fedora).noarch.rpm + "$ESCALATION_TOOL" "$PACKAGER" install -y "https://download1.rpmfusion.org/nonfree/fedora/rpmfusion-nonfree-release-$(rpm -E %fedora).noarch.rpm" "$ESCALATION_TOOL" "$PACKAGER" install -y discord ;; apk) @@ -36,4 +36,4 @@ installDiscord() { checkEnv checkEscalationTool -installDiscord \ No newline at end of file +installDiscord diff --git a/core/tabs/applications-setup/communication-apps/signal-setup.sh b/core/tabs/applications-setup/communication-apps/signal-setup.sh index 18c462b1..48f72ddb 100644 --- a/core/tabs/applications-setup/communication-apps/signal-setup.sh +++ b/core/tabs/applications-setup/communication-apps/signal-setup.sh @@ -8,7 +8,7 @@ installSignal() { case "$PACKAGER" in apt-get|nala) curl -fsSL https://updates.signal.org/desktop/apt/keys.asc | gpg --dearmor > signal-desktop-keyring.gpg - cat signal-desktop-keyring.gpg | "$ESCALATION_TOOL" tee /usr/share/keyrings/signal-desktop-keyring.gpg > /dev/null + "$ESCALATION_TOOL" tee /usr/share/keyrings/signal-desktop-keyring.gpg < signal-desktop-keyring.gpg > /dev/null printf "%b\n" 'deb [arch=amd64 signed-by=/usr/share/keyrings/signal-desktop-keyring.gpg] https://updates.signal.org/desktop/apt xenial main' | "$ESCALATION_TOOL" tee /etc/apt/sources.list.d/signal-xenial.list "$ESCALATION_TOOL" "$PACKAGER" update "$ESCALATION_TOOL" "$PACKAGER" -y install signal-desktop @@ -39,4 +39,4 @@ installSignal() { checkEnv checkEscalationTool -installSignal \ No newline at end of file +installSignal diff --git a/core/tabs/applications-setup/dwmtitus-setup.sh b/core/tabs/applications-setup/dwmtitus-setup.sh index be23b9ad..fa827700 100755 --- a/core/tabs/applications-setup/dwmtitus-setup.sh +++ b/core/tabs/applications-setup/dwmtitus-setup.sh @@ -192,7 +192,7 @@ setupDisplayManager() { "$ESCALATION_TOOL" "$PACKAGER" install -y xorg-x11-xinit xorg-x11-server-Xorg ;; *) - printf "%b\n" "${RED}Unsupported package manager: "$PACKAGER"${RC}" + printf "%b\n" "${RED}Unsupported package manager: $PACKAGER${RC}" exit 1 ;; esac @@ -244,7 +244,7 @@ setupDisplayManager() { "$ESCALATION_TOOL" "$PACKAGER" install -y "$DM" ;; *) - printf "%b\n" "${RED}Unsupported package manager: "$PACKAGER"${RC}" + printf "%b\n" "${RED}Unsupported package manager: $PACKAGER${RC}" exit 1 ;; esac diff --git a/core/tabs/applications-setup/linutil-installer.sh b/core/tabs/applications-setup/linutil-installer.sh index 13776fc3..c5af5045 100755 --- a/core/tabs/applications-setup/linutil-installer.sh +++ b/core/tabs/applications-setup/linutil-installer.sh @@ -53,7 +53,7 @@ installLinutil() { ;; *) curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y - . $HOME/.cargo/env + . "$HOME/.cargo/env" ;; esac fi diff --git a/core/tabs/applications-setup/linutil-updater.sh b/core/tabs/applications-setup/linutil-updater.sh index 4e399a02..1ccf9090 100755 --- a/core/tabs/applications-setup/linutil-updater.sh +++ b/core/tabs/applications-setup/linutil-updater.sh @@ -17,7 +17,7 @@ updateLinutil() { zypper) "$ESCALATION_TOOL" "$PACKAGER" install -n curl gcc make curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh - . $HOME/.cargo/env + . "$HOME/.cargo/env" ;; apk) "$ESCALATION_TOOL" "$PACKAGER" add build-base diff --git a/core/tabs/system-setup/compile-setup.sh b/core/tabs/system-setup/compile-setup.sh index bb6bb44a..746d1d5f 100755 --- a/core/tabs/system-setup/compile-setup.sh +++ b/core/tabs/system-setup/compile-setup.sh @@ -15,33 +15,33 @@ installDepend() { else printf "%b\n" "${GREEN}Multilib is already enabled.${RC}" fi - "$AUR_HELPER" -S --needed --noconfirm $DEPENDENCIES + "$AUR_HELPER" -S --needed --noconfirm "$DEPENDENCIES" ;; apt-get|nala) COMPILEDEPS='build-essential' "$ESCALATION_TOOL" "$PACKAGER" update "$ESCALATION_TOOL" dpkg --add-architecture i386 "$ESCALATION_TOOL" "$PACKAGER" update - "$ESCALATION_TOOL" "$PACKAGER" install -y $DEPENDENCIES $COMPILEDEPS + "$ESCALATION_TOOL" "$PACKAGER" install -y "$DEPENDENCIES" "$COMPILEDEPS" ;; dnf) COMPILEDEPS='@development-tools' "$ESCALATION_TOOL" "$PACKAGER" update "$ESCALATION_TOOL" "$PACKAGER" config-manager --set-enabled powertools - "$ESCALATION_TOOL" "$PACKAGER" install -y $DEPENDENCIES $COMPILEDEPS + "$ESCALATION_TOOL" "$PACKAGER" install -y "$DEPENDENCIES" "$COMPILEDEPS" "$ESCALATION_TOOL" "$PACKAGER" install -y glibc-devel.i686 libgcc.i686 ;; zypper) COMPILEDEPS='patterns-devel-base-devel_basis' "$ESCALATION_TOOL" "$PACKAGER" refresh - "$ESCALATION_TOOL" "$PACKAGER" --non-interactive install $DEPENDENCIES $COMPILEDEPS + "$ESCALATION_TOOL" "$PACKAGER" --non-interactive install "$DEPENDENCIES" "$COMPILEDEPS" "$ESCALATION_TOOL" "$PACKAGER" --non-interactive install libgcc_s1-gcc7-32bit glibc-devel-32bit ;; apk) "$ESCALATION_TOOL" "$PACKAGER" add build-base multitail tar tree trash-cli unzip cmake jq ;; *) - "$ESCALATION_TOOL" "$PACKAGER" install -y $DEPENDENCIES + "$ESCALATION_TOOL" "$PACKAGER" install -y "$DEPENDENCIES" ;; esac } @@ -49,4 +49,4 @@ installDepend() { checkEnv checkAURHelper checkEscalationTool -installDepend \ No newline at end of file +installDepend diff --git a/core/tabs/system-setup/system-cleanup.sh b/core/tabs/system-setup/system-cleanup.sh index dccbcf3a..70cfd5b6 100755 --- a/core/tabs/system-setup/system-cleanup.sh +++ b/core/tabs/system-setup/system-cleanup.sh @@ -22,7 +22,7 @@ cleanup_system() { ;; pacman) "$ESCALATION_TOOL" "$PACKAGER" -Sc --noconfirm - "$ESCALATION_TOOL" "$PACKAGER" -Rns $(pacman -Qtdq) --noconfirm > /dev/null || true + "$ESCALATION_TOOL" "$PACKAGER" -Rns "$(pacman -Qtdq)" --noconfirm > /dev/null || true ;; apk) "$ESCALATION_TOOL" "$PACKAGER" cache clean diff --git a/core/tabs/utils/bluetooth-control.sh b/core/tabs/utils/bluetooth-control.sh index 6bfe266b..f18a32a1 100644 --- a/core/tabs/utils/bluetooth-control.sh +++ b/core/tabs/utils/bluetooth-control.sh @@ -65,12 +65,11 @@ scan_devices() { printf "%b\n" "$devices" fi printf "%b" "Press any key to return to the main menu..." - read -r dummy + read -r _ } # Function to prompt for MAC address using numbers prompt_for_mac() { - action=$1 command=$2 prompt_msg=$3 success_msg=$4 @@ -82,14 +81,14 @@ prompt_for_mac() { if [ -z "$devices" ]; then printf "%b\n" "${RED}No devices available. Please scan for devices first.${RC}" printf "%b" "Press any key to return to the main menu..." - read -r dummy + read -r _ return fi # Display devices with numbers device_list=$(echo "$devices" | tr '\n' '\n') i=1 - echo "$device_list" | while IFS= read -r device; do + for device in $device_list; do printf "%d. %s\n" "$i" "$device" i=$((i + 1)) done @@ -102,12 +101,12 @@ prompt_for_mac() { device=$(echo "$device_list" | sed -n "${choice}p") mac=$(echo "$device" | awk '{print $2}') if bluetoothctl info "$mac" > /dev/null 2>&1; then - bluetoothctl "$command" "$mac" && { + if bluetoothctl "$command" "$mac"; then printf "%b\n" "${GREEN}$success_msg${RC}" break - } || { + else printf "%b\n" "${RED}$failure_msg${RC}" - } + fi else printf "%b\n" "${RED}Invalid MAC address. Please try again.${RC}" fi @@ -118,7 +117,7 @@ prompt_for_mac() { fi done printf "%b" "Press any key to return to the main menu..." - read -r dummy + read -r _ } # Function to pair with a device diff --git a/core/tabs/utils/encrypt_decrypt_tool.sh b/core/tabs/utils/encrypt_decrypt_tool.sh index 40e006a2..80e8bbc8 100644 --- a/core/tabs/utils/encrypt_decrypt_tool.sh +++ b/core/tabs/utils/encrypt_decrypt_tool.sh @@ -62,11 +62,11 @@ encrypt_file() { if [ -d "$INPUT_PATH" ]; then # Encrypt each file in the directory find "$INPUT_PATH" -type f | while read -r FILE; do - REL_PATH="${FILE#$INPUT_PATH/}" + REL_PATH="${FILE#"$INPUT_PATH"/}" OUTPUT_FILE="$OUTPUT_PATH/$REL_PATH.enc" mkdir -p "$(dirname "$OUTPUT_FILE")" - openssl enc -aes-256-cbc -salt -pbkdf2 -in "$FILE" -out "$OUTPUT_FILE" -k "$PASSWORD" - if [ $? -eq 0 ]; then + + if [ "$(openssl enc -aes-256-cbc -salt -pbkdf2 -in "$FILE" -out "$OUTPUT_FILE" -k "$PASSWORD")" -eq 0 ]; then printf "%b\n" "Encrypted: $OUTPUT_FILE" else printf "%b\n" "Failed to encrypt: $FILE" @@ -79,8 +79,8 @@ encrypt_file() { return fi mkdir -p "$(dirname "$OUTPUT_PATH")" - openssl enc -aes-256-cbc -salt -pbkdf2 -in "$INPUT_PATH" -out "$OUTPUT_PATH" -k "$PASSWORD" - if [ $? -eq 0 ]; then + + if [ "$(openssl enc -aes-256-cbc -salt -pbkdf2 -in "$INPUT_PATH" -out "$OUTPUT_PATH" -k "$PASSWORD")" -eq 0 ]; then printf "%b\n" "Encrypted: $OUTPUT_PATH" else printf "%b\n" "Failed to encrypt: $INPUT_PATH" @@ -107,11 +107,11 @@ decrypt_file() { if [ -d "$INPUT_PATH" ]; then # Decrypt each file in the directory find "$INPUT_PATH" -type f -name '*.enc' | while read -r FILE; do - REL_PATH="${FILE#$INPUT_PATH/}" + REL_PATH="${FILE#"$INPUT_PATH"/}" OUTPUT_FILE="$OUTPUT_PATH/${REL_PATH%.enc}" mkdir -p "$(dirname "$OUTPUT_FILE")" - openssl enc -aes-256-cbc -d -pbkdf2 -in "$FILE" -out "$OUTPUT_FILE" -k "$PASSWORD" - if [ $? -eq 0 ]; then + + if [ "$(openssl enc -aes-256-cbc -d -pbkdf2 -in "$FILE" -out "$OUTPUT_FILE" -k "$PASSWORD")" -eq 0 ]; then printf "%b\n" "Decrypted: $OUTPUT_FILE" else printf "%b\n" "Failed to decrypt: $FILE" @@ -124,8 +124,8 @@ decrypt_file() { return fi mkdir -p "$(dirname "$OUTPUT_PATH")" - openssl enc -aes-256-cbc -d -pbkdf2 -in "$INPUT_PATH" -out "$OUTPUT_PATH" -k "$PASSWORD" - if [ $? -eq 0 ]; then + + if [ "$(openssl enc -aes-256-cbc -d -pbkdf2 -in "$INPUT_PATH" -out "$OUTPUT_PATH" -k "$PASSWORD")" -eq 0 ]; then printf "%b\n" "Decrypted: $OUTPUT_PATH" else printf "%b\n" "Failed to decrypt: $INPUT_PATH" @@ -148,10 +148,10 @@ main(){ esac printf "%b\n" "Press [Enter] to continue..." - read -r dummy + read -r _ done } checkEnv checkEscalationTool -main \ No newline at end of file +main diff --git a/core/tabs/utils/monitor-control/set_brightness.sh b/core/tabs/utils/monitor-control/set_brightness.sh index 0b7a2a83..ce77e35b 100755 --- a/core/tabs/utils/monitor-control/set_brightness.sh +++ b/core/tabs/utils/monitor-control/set_brightness.sh @@ -29,7 +29,7 @@ adjust_monitor_brightness() { if ! echo "$monitor_choice" | grep -qE '^[0-9]+$'; then printf "%b\n" "${RED}Invalid selection. Please try again.${RC}" printf "Press [Enter] to continue..." - read -r dummy + read -r _ continue fi @@ -37,7 +37,7 @@ adjust_monitor_brightness() { if [ "$monitor_choice" -lt 1 ] || [ "$monitor_choice" -gt "$monitor_count" ]; then printf "%b\n" "${RED}Invalid selection. Please try again.${RC}" printf "Press [Enter] to continue..." - read -r dummy + read -r _ continue fi diff --git a/core/tabs/utils/monitor-control/set_resolutions.sh b/core/tabs/utils/monitor-control/set_resolutions.sh index 84aea4d5..9dbb7eaf 100755 --- a/core/tabs/utils/monitor-control/set_resolutions.sh +++ b/core/tabs/utils/monitor-control/set_resolutions.sh @@ -33,7 +33,7 @@ set_resolutions() { if ! echo "$monitor_choice" | grep -qE '^[0-9]+$' || [ "$monitor_choice" -lt 1 ] || [ "$monitor_choice" -gt "$((i - 1))" ]; then printf "%b\n" "${RED}Invalid selection. Please try again.${RC}" printf "%b\n" "Press [Enter] to continue..." - read -r dummy + read -r _ continue fi diff --git a/core/tabs/utils/ollama.sh b/core/tabs/utils/ollama.sh index 5552c4f9..47f99539 100644 --- a/core/tabs/utils/ollama.sh +++ b/core/tabs/utils/ollama.sh @@ -85,7 +85,8 @@ run_model() { printf "%b\n" "${installed_models}" printf "%b\n" "${YELLOW}Custom Models${RC}" - custom_models=$(ollama list | grep 'custom-model-prefix') + custom_models=$(ollama list | grep 'custom-model-prefix') + printf "%b\n" "${custom_models}" printf "%b" "Select a model to run: " printf "%b" "Enter the number corresponding to the model or enter the name of a custom model: " @@ -195,7 +196,7 @@ menu() { esac printf "%b\n" "${YELLOW}Press Enter to continue...${RC}" - read -r dummy + read -r _ done } diff --git a/core/tabs/utils/samba-ssh-setup.sh b/core/tabs/utils/samba-ssh-setup.sh index aa0dc30e..2de1bf7d 100755 --- a/core/tabs/utils/samba-ssh-setup.sh +++ b/core/tabs/utils/samba-ssh-setup.sh @@ -173,7 +173,7 @@ setup_ssh_samba(){ printf "%b\n" "5. Exit" printf "%b" "Enter your choice (1-5): " - read CHOICE + read -r CHOICE case "$CHOICE" in 1) @@ -205,4 +205,4 @@ setup_ssh_samba(){ checkEnv checkEscalationTool -setup_ssh_samba \ No newline at end of file +setup_ssh_samba diff --git a/core/tabs/utils/service-control.sh b/core/tabs/utils/service-control.sh index 903fa826..ea51089f 100644 --- a/core/tabs/utils/service-control.sh +++ b/core/tabs/utils/service-control.sh @@ -267,10 +267,10 @@ main() { esac printf "%b\n" "Press [Enter] to continue..." - read -r dummy + read -r _ done } checkEnv checkEscalationTool -main \ No newline at end of file +main diff --git a/core/tabs/utils/timeshift.sh b/core/tabs/utils/timeshift.sh index b38483e5..3b932c25 100644 --- a/core/tabs/utils/timeshift.sh +++ b/core/tabs/utils/timeshift.sh @@ -67,6 +67,7 @@ create_snapshot() { "$ESCALATION_TOOL" timeshift --create --comments "$COMMENT" --tags "$TAG" fi + # shellcheck disable=SC2181 if [ $? -eq 0 ]; then printf "%b\n" "${GREEN}Snapshot created successfully.${RC}" else @@ -93,6 +94,7 @@ restore_snapshot() { "$ESCALATION_TOOL" timeshift --restore --snapshot "$SNAPSHOT" --target-device "$TARGET_DEVICE" --grub-device "$GRUB_DEVICE" --yes fi + # shellcheck disable=SC2181 if [ $? -eq 0 ]; then printf "%b\n" "${GREEN}Snapshot restored successfully.${RC}" else @@ -110,6 +112,7 @@ delete_snapshot() { printf "%b\n" "${YELLOW}Deleting snapshot $SNAPSHOT...${RC}" "$ESCALATION_TOOL" timeshift --delete --snapshot "$SNAPSHOT" --yes + # shellcheck disable=SC2181 if [ $? -eq 0 ]; then printf "%b\n" "${GREEN}Snapshot deleted successfully.${RC}" else @@ -126,6 +129,7 @@ delete_all_snapshots() { if [ "$CONFIRMATION" = "y" ] || [ "$CONFIRMATION" = "Y" ]; then printf "%b\n" "${CYAN}Deleting all snapshots...${RC}" "$ESCALATION_TOOL" timeshift --delete-all --yes + # shellcheck disable=SC2181 if [ $? -eq 0 ]; then printf "%b\n" "${GREEN}All snapshots deleted successfully.${RC}" else @@ -153,7 +157,7 @@ main_menu() { *) printf "%b\n" "${RED}Invalid option. Please try again.${RC}" ;; esac printf "%b\n" "${CYAN}Press Enter to continue...${RC}" - read -r dummy + read -r _ done } diff --git a/core/tabs/utils/user-account-manager/add_to_group.sh b/core/tabs/utils/user-account-manager/add_to_group.sh index 665cf72a..07720505 100755 --- a/core/tabs/utils/user-account-manager/add_to_group.sh +++ b/core/tabs/utils/user-account-manager/add_to_group.sh @@ -33,7 +33,7 @@ addToGroup() { groups_to_add=$(echo "$groups" | tr ' ' ',') printf "%b" "${YELLOW}Are you sure you want to add user $username to $groups_to_add? [Y/n]: ${RC}" - read -r confirm + read -r _ confirmAction || exit 1 "$ESCALATION_TOOL" usermod -aG "$groups_to_add" "$username" @@ -44,4 +44,4 @@ addToGroup() { checkEnv checkEscalationTool checkGroups -addToGroup \ No newline at end of file +addToGroup diff --git a/core/tabs/utils/user-account-manager/change_password.sh b/core/tabs/utils/user-account-manager/change_password.sh index a909a5b2..20706bd3 100755 --- a/core/tabs/utils/user-account-manager/change_password.sh +++ b/core/tabs/utils/user-account-manager/change_password.sh @@ -17,7 +17,7 @@ changePassword() { read -r password printf "%b" "${YELLOW}Are you sure you want to change password for ""$username""? [Y/n]: ${RC}" - read -r confirm + read -r _ confirmAction || exit 1 echo "$username:$password" | "$ESCALATION_TOOL" chpasswd @@ -30,4 +30,4 @@ changePassword() { checkEnv checkEscalationTool -changePassword \ No newline at end of file +changePassword diff --git a/core/tabs/utils/user-account-manager/delete_user.sh b/core/tabs/utils/user-account-manager/delete_user.sh index aee9482e..f4795872 100755 --- a/core/tabs/utils/user-account-manager/delete_user.sh +++ b/core/tabs/utils/user-account-manager/delete_user.sh @@ -14,7 +14,7 @@ deleteUser() { if id "$username" > /dev/null 2>&1; then printf "%b" "${YELLOW}Are you sure you want to delete user ""$username""? [Y/n]: ${RC}" - read -r confirm + read -r _ confirmAction || exit 1 $ESCALATION_TOOL userdel --remove "$username" 2>/dev/null @@ -27,4 +27,4 @@ deleteUser() { checkEnv checkEscalationTool -deleteUser \ No newline at end of file +deleteUser diff --git a/core/tabs/utils/user-account-manager/remove_from_group.sh b/core/tabs/utils/user-account-manager/remove_from_group.sh index 23935b5e..1c07b006 100755 --- a/core/tabs/utils/user-account-manager/remove_from_group.sh +++ b/core/tabs/utils/user-account-manager/remove_from_group.sh @@ -34,14 +34,14 @@ removeFromGroup() { groups_to_remove=$(echo "$groups" | tr ' ' ',') printf "%b" "${YELLOW}Are you sure you want to remove user $username from $groups_to_remove? [Y/n]: ${RC}" - read -r confirm + read -r _ confirmAction || exit 1 - $ESCALATION_TOOL usermod -rG $groups_to_remove "$username" + $ESCALATION_TOOL usermod -rG "$groups_to_remove" "$username" printf "%b\n" "${GREEN}User successfully removed from $groups_to_remove${RC}" } checkEnv checkEscalationTool -removeFromGroup \ No newline at end of file +removeFromGroup diff --git a/core/tabs/utils/utility_functions.sh b/core/tabs/utils/utility_functions.sh index 09f33c60..acadee68 100755 --- a/core/tabs/utils/utility_functions.sh +++ b/core/tabs/utils/utility_functions.sh @@ -30,6 +30,7 @@ execute_command() { command="$1" printf "Executing: %s\n" "$command" eval "$command" 2>&1 | tee /tmp/xrandr.log | tail -n 20 + # shellcheck disable=SC2181 if [ $? -ne 0 ]; then printf "%b\n" "${RED}An error occurred while executing the command. Check /tmp/xrandr.log for details.${RC}" fi diff --git a/core/tabs/utils/wifi-control.sh b/core/tabs/utils/wifi-control.sh index d4ed2d10..0a8f0515 100755 --- a/core/tabs/utils/wifi-control.sh +++ b/core/tabs/utils/wifi-control.sh @@ -75,33 +75,33 @@ scan_networks() { echo "$networks" | awk -F: '{printf("%d. SSID: %-25s \n", NR, $1)}' fi printf "%b\n" "Press any key to return to the main menu..." - read -r dummy + read -r _ } # Function to turn WiFi on wifi_on() { clear printf "%b\n" "${YELLOW}Turning WiFi on...${RC}" - nmcli radio wifi on && { + if "$(nmcli radio wifi on)"; then printf "%b\n" "${GREEN}WiFi is now turned on.${RC}" - } || { + else printf "%b\n" "${RED}Failed to turn on WiFi.${RC}" - } + fi printf "%b\n" "Press any key to return to the main menu..." - read -r dummy + read -r _ } # Function to turn WiFi off wifi_off() { clear printf "%b\n" "${YELLOW}Turning WiFi off...${RC}" - nmcli radio wifi off && { + if "$(nmcli radio wifi off)"; then printf "%b\n" "${GREEN}WiFi is now turned off.${RC}" - } || { + else printf "%b\n" "${RED}Failed to turn off WiFi.${RC}" - } + fi printf "%b\n" "Press any key to return to the main menu..." - read -r dummy + read -r _ } # Function to prompt for WiFi network selection @@ -118,7 +118,7 @@ prompt_for_network() { if [ -z "$networks" ]; then printf "%b\n" "${RED}No networks available. Please scan for networks first.${RC}" printf "%b\n" "Press any key to return to the main menu..." - read -r dummy + read -r _ rm -f "$temp_file" return fi @@ -142,18 +142,18 @@ prompt_for_network() { printf "%b" "Enter password for SSID: " "$ssid" read -r password printf "\n" - nmcli dev wifi connect "$ssid" password "$password" && { + if "$(nmcli dev wifi connect "$ssid" password "$password")"; then printf "%b\n" "${GREEN}$success_msg${RC}" - } || { + else printf "%b\n" "${RED}$failure_msg${RC}" - } + fi fi else printf "%b\n" "${RED}Invalid choice. Please try again.${RC}" fi printf "%b\n" "Press any key to return to the selection menu..." - read -r dummy + read -r _ done rm -f "$temp_file" @@ -178,4 +178,4 @@ remove_network() { checkEnv checkEscalationTool setupNetworkManager -main_menu \ No newline at end of file +main_menu From 81913acb90a108ea477d5bff6b178e3f05b30c93 Mon Sep 17 00:00:00 2001 From: Liam <33645555+lj3954@users.noreply.github.com> Date: Sat, 1 Feb 2025 22:05:43 -0600 Subject: [PATCH 3/9] refactor: Use a macro to simplify shortcut creation (#973) --- tui/src/confirmation.rs | 16 +++++----- tui/src/floating_text.rs | 16 +++++----- tui/src/hint.rs | 11 +++++++ tui/src/running_command.rs | 24 +++++++-------- tui/src/state.rs | 62 ++++++++++++++++++++------------------ 5 files changed, 71 insertions(+), 58 deletions(-) diff --git a/tui/src/confirmation.rs b/tui/src/confirmation.rs index 3a4e9578..ea465fcc 100644 --- a/tui/src/confirmation.rs +++ b/tui/src/confirmation.rs @@ -1,4 +1,4 @@ -use crate::{float::FloatContent, hint::Shortcut, theme}; +use crate::{float::FloatContent, hint::Shortcut, shortcuts, theme}; use ratatui::{ crossterm::event::{KeyCode, KeyEvent, MouseEvent, MouseEventKind}, layout::Alignment, @@ -135,13 +135,13 @@ impl FloatContent for ConfirmPrompt { fn get_shortcut_list(&self) -> (&str, Box<[Shortcut]>) { ( "Confirmation prompt", - Box::new([ - Shortcut::new("Continue", ["Y", "y"]), - Shortcut::new("Abort", ["N", "n", "q", "Esc"]), - Shortcut::new("Scroll up", ["k", "Up"]), - Shortcut::new("Scroll down", ["j", "Down"]), - Shortcut::new("Close linutil", ["CTRL-c"]), - ]), + shortcuts!( + ("Continue", ["Y", "y"]), + ("Abort", ["N", "n", "q", "Esc"]), + ("Scroll up", ["k", "Up"]), + ("Scroll down", ["j", "Down"]), + ("Close linutil", ["CTRL-c"]), + ), ) } } diff --git a/tui/src/floating_text.rs b/tui/src/floating_text.rs index 13ae33d7..ee5321ea 100644 --- a/tui/src/floating_text.rs +++ b/tui/src/floating_text.rs @@ -1,4 +1,4 @@ -use crate::{float::FloatContent, hint::Shortcut, theme::Theme}; +use crate::{float::FloatContent, hint::Shortcut, shortcuts, theme::Theme}; use linutil_core::Command; use ratatui::{ crossterm::event::{KeyCode, KeyEvent, MouseEvent, MouseEventKind}, @@ -228,13 +228,13 @@ impl FloatContent for FloatingText<'_> { fn get_shortcut_list(&self) -> (&str, Box<[Shortcut]>) { ( &self.mode_title, - Box::new([ - Shortcut::new("Scroll down", ["j", "Down"]), - Shortcut::new("Scroll up", ["k", "Up"]), - Shortcut::new("Scroll left", ["h", "Left"]), - Shortcut::new("Scroll right", ["l", "Right"]), - Shortcut::new("Close window", ["Enter", "p", "q", "d", "g"]), - ]), + shortcuts!( + ("Scroll down", ["j", "Down"]), + ("Scroll up", ["k", "Up"]), + ("Scroll left", ["h", "Left"]), + ("Scroll right", ["l", "Right"]), + ("Close window", ["Enter", "p", "q", "d", "g"]) + ), ) } } diff --git a/tui/src/hint.rs b/tui/src/hint.rs index 2849961f..eda009a6 100644 --- a/tui/src/hint.rs +++ b/tui/src/hint.rs @@ -78,3 +78,14 @@ impl Shortcut { .collect() } } + +#[macro_export] +macro_rules! shortcuts { + ($(($name:literal,[$($key:literal),+ $(,)?])),* $(,)?) => { + vec![ + $( + Shortcut::new($name, [$($key),*]) + ),* + ].into_boxed_slice() + }; +} diff --git a/tui/src/running_command.rs b/tui/src/running_command.rs index d2342826..378eec4d 100644 --- a/tui/src/running_command.rs +++ b/tui/src/running_command.rs @@ -1,4 +1,4 @@ -use crate::{float::FloatContent, hint::Shortcut, theme::Theme}; +use crate::{float::FloatContent, hint::Shortcut, shortcuts, theme::Theme}; use linutil_core::Command; use oneshot::{channel, Receiver}; use portable_pty::{ @@ -139,21 +139,21 @@ impl FloatContent for RunningCommand { if self.is_finished() { ( "Finished command", - Box::new([ - Shortcut::new("Close window", ["Enter", "q"]), - Shortcut::new("Scroll up", ["Page up"]), - Shortcut::new("Scroll down", ["Page down"]), - Shortcut::new("Save log", ["l"]), - ]), + shortcuts!( + ("Close window", ["Enter", "q"]), + ("Scroll up", ["Page up"]), + ("Scroll down", ["Page down"]), + ("Save log", ["l"]), + ), ) } else { ( "Running command", - Box::new([ - Shortcut::new("Kill the command", ["CTRL-c"]), - Shortcut::new("Scroll up", ["Page up"]), - Shortcut::new("Scroll down", ["Page down"]), - ]), + shortcuts!( + ("Kill the command", ["CTRL-c"]), + ("Scroll up", ["Page up"]), + ("Scroll down", ["Page down"]), + ), ) } } diff --git a/tui/src/state.rs b/tui/src/state.rs index 1715b7e6..4bcb9c48 100644 --- a/tui/src/state.rs +++ b/tui/src/state.rs @@ -6,6 +6,7 @@ use crate::{ hint::{create_shortcut_list, Shortcut}, root::check_root_status, running_command::RunningCommand, + shortcuts, theme::Theme, Args, }; @@ -171,13 +172,13 @@ impl AppState { fn get_list_item_shortcut(&self) -> Box<[Shortcut]> { if self.selected_item_is_dir() { - Box::new([Shortcut::new("Go to selected dir", ["l", "Right", "Enter"])]) + shortcuts!(("Go to selected dir", ["l", "Right", "Enter"])) } else { - Box::new([ - Shortcut::new("Run selected command", ["l", "Right", "Enter"]), - Shortcut::new("Enable preview", ["p"]), - Shortcut::new("Command Description", ["d"]), - ]) + shortcuts!( + ("Run selected command", ["l", "Right", "Enter"]), + ("Enable preview", ["p"]), + ("Command Description", ["d"]) + ) } } @@ -185,10 +186,7 @@ impl AppState { match self.focus { Focus::Search => ( "Search bar", - Box::new([ - Shortcut::new("Abort search", ["Esc", "CTRL-c"]), - Shortcut::new("Search", ["Enter"]), - ]), + shortcuts!(("Abort search", ["Esc", "CTRL-c"]), ("Search", ["Enter"])), ), Focus::List => { @@ -208,35 +206,39 @@ impl AppState { hints.extend(self.get_list_item_shortcut()); } - hints.push(Shortcut::new("Select item above", ["k", "Up"])); - hints.push(Shortcut::new("Select item below", ["j", "Down"])); - hints.push(Shortcut::new("Next theme", ["t"])); - hints.push(Shortcut::new("Previous theme", ["T"])); - hints.push(Shortcut::new("Multi-selection mode", ["v"])); + hints.extend(shortcuts!( + ("Select item above", ["k", "Up"]), + ("Select item below", ["j", "Down"]), + ("Next theme", ["t"]), + ("Previous theme", ["T"]), + ("Multi-selection mode", ["v"]), + )); if self.multi_select { hints.push(Shortcut::new("Select multiple commands", ["Space"])); } - hints.push(Shortcut::new("Next tab", ["Tab"])); - hints.push(Shortcut::new("Previous tab", ["Shift-Tab"])); - hints.push(Shortcut::new("Important actions guide", ["g"])); + hints.extend(shortcuts!( + ("Next tab", ["Tab"]), + ("Previous tab", ["Shift-Tab"]), + ("Important actions guide", ["g"]) + )); ("Command list", hints.into_boxed_slice()) } Focus::TabList => ( "Tab list", - Box::new([ - Shortcut::new("Exit linutil", ["q", "CTRL-c"]), - Shortcut::new("Focus action list", ["l", "Right", "Enter"]), - Shortcut::new("Select item above", ["k", "Up"]), - Shortcut::new("Select item below", ["j", "Down"]), - Shortcut::new("Next theme", ["t"]), - Shortcut::new("Previous theme", ["T"]), - Shortcut::new("Next tab", ["Tab"]), - Shortcut::new("Previous tab", ["Shift-Tab"]), - Shortcut::new("Important actions guide", ["g"]), - Shortcut::new("Multi-selection mode", ["v"]), - ]), + shortcuts!( + ("Exit linutil", ["q", "CTRL-c"]), + ("Focus action list", ["l", "Right", "Enter"]), + ("Select item above", ["k", "Up"]), + ("Select item below", ["j", "Down"]), + ("Next theme", ["t"]), + ("Previous theme", ["T"]), + ("Next tab", ["Tab"]), + ("Previous tab", ["Shift-Tab"]), + ("Important actions guide", ["g"]), + ("Multi-selection mode", ["v"]), + ), ), Focus::FloatingWindow(ref float) => float.get_shortcut_list(), From e373f2cde894dc868de7964f9481e1712cfa99dc Mon Sep 17 00:00:00 2001 From: Jeevitha Kannan K S Date: Sun, 2 Feb 2025 09:37:11 +0530 Subject: [PATCH 4/9] refact: categorize dev scripts & add zed editor installation (#929) * feat: Add zed editor -> developer tools * Rename dir Developer-tools -> developer-tools * Rename files from application-setup.sh -> application.sh The purpose of all files inside the directory is to setup an application no need to mention it in the file name * Revert userguide.md zed * docs: new repo (#888) * Removes docs and mentions on readme * Update README.md * Update README.md Co-authored-by: Adam Perkowski * Update linutil.yml * Delete xtask.yml * Update preview.yml * Update README.md --------- Co-authored-by: Chris Titus Co-authored-by: Adam Perkowski * fix(create-bootable-usb.sh) confirmation prompt (#902) * fix create-bootable-usb.sh confirmation prompt * Update core/tabs/utils/create-bootable-usb.sh Co-authored-by: Liam <33645555+lj3954@users.noreply.github.com> --------- Co-authored-by: Liam <33645555+lj3954@users.noreply.github.com> * fix (ci): preview workflow (#905) * fix: binary download, invalid action inputs * Update preview.yml --------- Co-authored-by: Real-MullaC Co-authored-by: Chris Titus Co-authored-by: Adam Perkowski Co-authored-by: Lennart Pieperjohanns <95208734+lennartpj@users.noreply.github.com> Co-authored-by: Liam <33645555+lj3954@users.noreply.github.com> --- .../githubdesktop.sh} | 0 .../jetbrains-toolbox.sh | 0 .../meld-setup.sh => developer-tools/meld.sh} | 0 .../neovim.sh} | 0 .../ngrok.sh} | 0 .../sublime.sh} | 0 .../vscode.sh} | 0 .../vscodium.sh} | 0 .../applications-setup/developer-tools/zed.sh | 52 +++++++++++++++++++ core/tabs/applications-setup/tab_data.toml | 22 +++++--- 10 files changed, 66 insertions(+), 8 deletions(-) rename core/tabs/applications-setup/{Developer-tools/githubdesktop-setup.sh => developer-tools/githubdesktop.sh} (100%) rename core/tabs/applications-setup/{Developer-tools => developer-tools}/jetbrains-toolbox.sh (100%) rename core/tabs/applications-setup/{Developer-tools/meld-setup.sh => developer-tools/meld.sh} (100%) rename core/tabs/applications-setup/{Developer-tools/neovim-setup.sh => developer-tools/neovim.sh} (100%) rename core/tabs/applications-setup/{Developer-tools/ngrok-setup.sh => developer-tools/ngrok.sh} (100%) rename core/tabs/applications-setup/{Developer-tools/sublime-setup.sh => developer-tools/sublime.sh} (100%) rename core/tabs/applications-setup/{Developer-tools/vscode-setup.sh => developer-tools/vscode.sh} (100%) rename core/tabs/applications-setup/{Developer-tools/vscodium-setup.sh => developer-tools/vscodium.sh} (100%) create mode 100644 core/tabs/applications-setup/developer-tools/zed.sh diff --git a/core/tabs/applications-setup/Developer-tools/githubdesktop-setup.sh b/core/tabs/applications-setup/developer-tools/githubdesktop.sh similarity index 100% rename from core/tabs/applications-setup/Developer-tools/githubdesktop-setup.sh rename to core/tabs/applications-setup/developer-tools/githubdesktop.sh diff --git a/core/tabs/applications-setup/Developer-tools/jetbrains-toolbox.sh b/core/tabs/applications-setup/developer-tools/jetbrains-toolbox.sh similarity index 100% rename from core/tabs/applications-setup/Developer-tools/jetbrains-toolbox.sh rename to core/tabs/applications-setup/developer-tools/jetbrains-toolbox.sh diff --git a/core/tabs/applications-setup/Developer-tools/meld-setup.sh b/core/tabs/applications-setup/developer-tools/meld.sh similarity index 100% rename from core/tabs/applications-setup/Developer-tools/meld-setup.sh rename to core/tabs/applications-setup/developer-tools/meld.sh diff --git a/core/tabs/applications-setup/Developer-tools/neovim-setup.sh b/core/tabs/applications-setup/developer-tools/neovim.sh similarity index 100% rename from core/tabs/applications-setup/Developer-tools/neovim-setup.sh rename to core/tabs/applications-setup/developer-tools/neovim.sh diff --git a/core/tabs/applications-setup/Developer-tools/ngrok-setup.sh b/core/tabs/applications-setup/developer-tools/ngrok.sh similarity index 100% rename from core/tabs/applications-setup/Developer-tools/ngrok-setup.sh rename to core/tabs/applications-setup/developer-tools/ngrok.sh diff --git a/core/tabs/applications-setup/Developer-tools/sublime-setup.sh b/core/tabs/applications-setup/developer-tools/sublime.sh similarity index 100% rename from core/tabs/applications-setup/Developer-tools/sublime-setup.sh rename to core/tabs/applications-setup/developer-tools/sublime.sh diff --git a/core/tabs/applications-setup/Developer-tools/vscode-setup.sh b/core/tabs/applications-setup/developer-tools/vscode.sh similarity index 100% rename from core/tabs/applications-setup/Developer-tools/vscode-setup.sh rename to core/tabs/applications-setup/developer-tools/vscode.sh diff --git a/core/tabs/applications-setup/Developer-tools/vscodium-setup.sh b/core/tabs/applications-setup/developer-tools/vscodium.sh similarity index 100% rename from core/tabs/applications-setup/Developer-tools/vscodium-setup.sh rename to core/tabs/applications-setup/developer-tools/vscodium.sh diff --git a/core/tabs/applications-setup/developer-tools/zed.sh b/core/tabs/applications-setup/developer-tools/zed.sh new file mode 100644 index 00000000..150d6214 --- /dev/null +++ b/core/tabs/applications-setup/developer-tools/zed.sh @@ -0,0 +1,52 @@ +#!/bin/sh -e + +. ../../common-script.sh + +installZed() { + if ! command_exists dev.zed.Zed && ! command_exists zed && ! command_exists zeditor; then + printf "%b\n" "${CYAN}Installing Zed.${RC}" + case "$PACKAGER" in + apk) + "$ESCALATION_TOOL" "$PACKAGER" add zed + ;; + pacman) + "$ESCALATION_TOOL" "$PACKAGER" -S zed + ;; + zypper) + "$ESCALATION_TOOL" "$PACKAGER" addrepo -f https://download.opensuse.org/repositories/editors/openSUSE_Tumbleweed/editors.repo + "$ESCALATION_TOOL" "$PACKAGER" install -y zed + ;; + *) + printf "%b\n" "${YELLOW}No official package found for package manager $PACKAGER. Do you want to install flathub package or from source?${RC}" + printf "%b\n" "1) Flathub package" + printf "%b\n" "2) Source" + printf "%b\n" "3) Exit" + printf "%b" "Choose an option: " + read -r choice + case "$choice" in + 1) + checkFlatpak + flatpak install -y flathub dev.zed.Zed + ;; + 2) + curl -f https://zed.dev/install.sh | sh + ;; + 3) + printf "%b\n" "${GREEN}Exiting.${RC}" + exit 0 + ;; + *) + printf "%b\n" "${RED}Invalid option.${RC}" + exit 1 + ;; + esac + ;; + esac + else + printf "%b\n" "${GREEN}Zed is already installed.${RC}" + fi +} + +checkEnv +clear +installZed diff --git a/core/tabs/applications-setup/tab_data.toml b/core/tabs/applications-setup/tab_data.toml index 892c1abb..336293ca 100644 --- a/core/tabs/applications-setup/tab_data.toml +++ b/core/tabs/applications-setup/tab_data.toml @@ -57,49 +57,55 @@ name = "Developer Tools" [[data.entries]] name = "Github Desktop" description = "GitHub Desktop is a user-friendly application that simplifies the process of managing Git repositories and interacting with GitHub, providing a graphical interface for tasks like committing, branching, and syncing changes." -script = "Developer-tools/githubdesktop-setup.sh" +script = "developer-tools/githubdesktop.sh" task_list = "I" [[data.entries]] name = "JetBrains Toolbox" description = "JetBrains Toolbox is a collection of tools and an app that help developers work with JetBrains products." -script = "Developer-tools/jetbrains-toolbox.sh" +script = "developer-tools/jetbrains-toolbox.sh" task_list = "I" [[data.entries]] name = "Meld" description = "Meld is a visual diff and merge tool that helps compare files, directories, and version-controlled projects." -script = "Developer-tools/meld-setup.sh" +script = "developer-tools/meld.sh" task_list = "I FI" [[data.entries]] name = "Neovim" description = "Neovim is a refactor, and sometimes redactor, in the tradition of Vim.\nIt is not a rewrite but a continuation and extension of Vim.\nThis command configures neovim from CTT's neovim configuration.\nhttps://github.com/ChrisTitusTech/neovim" -script = "Developer-tools/neovim-setup.sh" +script = "developer-tools/neovim.sh" task_list = "I FM" [[data.entries]] name = "Ngrok" description = "Ngrok is a tool that creates secure, temporary tunnels to expose local servers to the internet for testing and development." -script = "Developer-tools/ngrok-setup.sh" +script = "developer-tools/ngrok.sh" task_list = "I" [[data.entries]] name = "Sublime Text" description = "Sublime Text is a fast, lightweight, and customizable text editor known for its simplicity, powerful features, and wide range of plugins for various programming languages." -script = "Developer-tools/sublime-setup.sh" +script = "developer-tools/sublime.sh" task_list = "I" [[data.entries]] name = "VS Code" description = "Visual Studio Code (VS Code) is a lightweight, open-source code editor with built-in support for debugging, version control, and extensions for various programming languages and frameworks." -script = "Developer-tools/vscode-setup.sh" +script = "developer-tools/vscode.sh" task_list = "I" [[data.entries]] name = "VS Codium" description = "VSCodium is a free, open-source version of Visual Studio Code (VS Code) that removes Microsoft-specific telemetry and branding." -script = "Developer-tools/vscodium-setup.sh" +script = "developer-tools/vscodium.sh" +task_list = "I" + +[[data.entries]] +name = "Zed" +description = "Zed is a next-generation code editor written in rust, designed for high-performance collaboration with humans and AI." +script = "developer-tools/zed.sh" task_list = "I" [[data]] From c3b563b98efc7e3491ab5a4b8675decaa9256189 Mon Sep 17 00:00:00 2001 From: Jeevitha Kannan K S Date: Sun, 2 Feb 2025 09:40:26 +0530 Subject: [PATCH 5/9] Fix grep error in alpine linux (#979) --- startdev.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/startdev.sh b/startdev.sh index 8e27bbf0..7e6b0bb2 100755 --- a/startdev.sh +++ b/startdev.sh @@ -8,8 +8,9 @@ RED='\033[0;31m' # Function to fetch the latest release tag from the GitHub API get_latest_release() { latest_release=$(curl -s https://api.github.com/repos/ChrisTitusTech/linutil/releases | - grep -oP '"tag_name": "\K[^"]*' | - head -n 1) + grep "tag_name" | + head -n 1 | + sed -E 's/.*"tag_name": "([^"]+)".*/\1/') if [ -z "$latest_release" ]; then printf "%b\n" "Error fetching release data" >&2 return 1 From 2d164d15b63f4f4fc5edb3885d68ea736a21a0ba Mon Sep 17 00:00:00 2001 From: Chris Titus Date: Sat, 1 Feb 2025 22:11:39 -0600 Subject: [PATCH 6/9] remove shfmt (#1012) --- .github/workflows/shellcheck.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml index e3be746d..85feed74 100644 --- a/.github/workflows/shellcheck.yml +++ b/.github/workflows/shellcheck.yml @@ -31,9 +31,3 @@ jobs: steps: - name: Checkout sources uses: actions/checkout@v4 - - - name: Run shfmt - uses: reviewdog/action-shfmt@v1 - with: - shfmt_flags: '-i 4 -ci' - reviewdog_flags: '-fail-level=any' From a6ccaf4a4ee664835f476c8ac4742b5077e4a03a Mon Sep 17 00:00:00 2001 From: D7OM <61534551+d7omdev@users.noreply.github.com> Date: Sun, 2 Feb 2025 07:13:06 +0300 Subject: [PATCH 7/9] feat: Zen Browser installation (#940) * Zen Browser installation - Added Zen Browser to Web Browsers tab. * Update core/tabs/applications-setup/browsers/zen-browser.sh Co-authored-by: Jeevitha Kannan K S * Revert changes to docs/userguide.md --------- Co-authored-by: Jeevitha Kannan K S --- .../browsers/zen-browser.sh | 29 +++++++++++++++++++ core/tabs/applications-setup/tab_data.toml | 8 ++++- 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100755 core/tabs/applications-setup/browsers/zen-browser.sh diff --git a/core/tabs/applications-setup/browsers/zen-browser.sh b/core/tabs/applications-setup/browsers/zen-browser.sh new file mode 100755 index 00000000..4cd7d932 --- /dev/null +++ b/core/tabs/applications-setup/browsers/zen-browser.sh @@ -0,0 +1,29 @@ +#!/bin/sh -e + +. ../../common-script.sh + +installZenBrowser() { + if ! command_exists io.github.zen_browser.zen && ! command_exists zen-browser; then + printf "%b\n" "${YELLOW}Installing Zen Browser...${RC}" + case "$PACKAGER" in + pacman) + if grep -q avx2 /proc/cpuinfo; then + "$AUR_HELPER" -S --needed --noconfirm zen-browser-avx2-bin + else + "$AUR_HELPER" -S --needed --noconfirm zen-browser-bin + fi + ;; + *) + checkFlatpak + flatpak install -y flathub io.github.zen_browser.zen + ;; + esac + else + printf "%b\n" "${GREEN}Zen Browser is already installed.${RC}" + fi +} + +checkEnv +checkEscalationTool +checkAURHelper +installZenBrowser diff --git a/core/tabs/applications-setup/tab_data.toml b/core/tabs/applications-setup/tab_data.toml index 336293ca..62eb71a1 100644 --- a/core/tabs/applications-setup/tab_data.toml +++ b/core/tabs/applications-setup/tab_data.toml @@ -192,6 +192,12 @@ description = "Mozilla Firefox is a free and open-source web browser developed b script = "browsers/firefox.sh" task_list = "I" +[[data.entries]] +name = "Zen Browser" +description = "Zen Browser is a privacy-focused web browser designed for enhanced security and a seamless browsing experience." +script = "browsers/zen-browser.sh" +task_list = "I" + [[data.entries]] name = "Thorium" description = "Thorium is a Chromium-based browser focused on privacy and performance." @@ -336,4 +342,4 @@ values = ["wayland", "Wayland"] name = "ZSH Prompt" description = "The Z shell is a Unix shell that can be used as an interactive login shell and as a command interpreter for shell scripting. Zsh is an extended Bourne shell with many improvements, including some features of Bash, ksh, and tcsh. This command installs ZSH prompt and provides basic configuration." script = "zsh-setup.sh" -task_list = "I FM" \ No newline at end of file +task_list = "I FM" From efa6ff9cd2eb77204028de361be008a68338aeb8 Mon Sep 17 00:00:00 2001 From: Chris Titus Date: Thu, 6 Feb 2025 15:14:09 -0600 Subject: [PATCH 8/9] allow different os-releases and hyprland setup (#1013) * allow different os-releases and hypr setup * Update core/src/inner.rs Co-authored-by: Adam Perkowski * Update core/tabs/system-setup/debian/hyprland-kool-deb.sh Co-authored-by: Adam Perkowski * Update core/tabs/system-setup/arch/hyprland-kool.sh Co-authored-by: Adam Perkowski * Update core/tabs/system-setup/fedora/hyprland-kool-fed.sh Co-authored-by: Adam Perkowski * Update core/tabs/system-setup/tab_data.toml Co-authored-by: Adam Perkowski * Update core/tabs/system-setup/tab_data.toml Co-authored-by: Adam Perkowski * Update core/tabs/system-setup/tab_data.toml Co-authored-by: Adam Perkowski * Update core/tabs/system-setup/tab_data.toml Co-authored-by: Adam Perkowski * Update core/tabs/system-setup/ubuntu/hyprland-kool-ubuntu24.sh Co-authored-by: Adam Perkowski * refactor: Improve File Contains precondition (#1016) * Update inner.rs (#1021) * Update inner.rs (#1022) * revert to liams commit * Update core/tabs/system-setup/arch/hyprland-kool.sh Co-authored-by: nyx * Update core/tabs/system-setup/debian/hyprland-kool-deb.sh Co-authored-by: nyx * Update core/tabs/system-setup/fedora/hyprland-kool-fed.sh Co-authored-by: nyx * Update core/tabs/system-setup/arch/hyprland-kool.sh Co-authored-by: nyx * Update core/tabs/system-setup/debian/hyprland-kool-deb.sh Co-authored-by: nyx * Update core/tabs/system-setup/debian/hyprland-kool-deb.sh Co-authored-by: nyx * Update core/tabs/system-setup/arch/hyprland-kool.sh Co-authored-by: nyx * Update core/tabs/system-setup/arch/hyprland-kool.sh Co-authored-by: nyx * Update core/tabs/system-setup/arch/hyprland-kool.sh Co-authored-by: nyx * Update core/tabs/system-setup/arch/hyprland-kool.sh Co-authored-by: nyx * fix bashisms * Switch to SH from bash --------- Co-authored-by: Adam Perkowski Co-authored-by: Liam <33645555+lj3954@users.noreply.github.com> Co-authored-by: nyx --- core/src/inner.rs | 23 ++++---- core/tabs/system-setup/arch/hyprland-kool.sh | 15 ++++++ .../system-setup/debian/hyprland-kool-deb.sh | 9 ++++ .../system-setup/fedora/hyprland-kool-fed.sh | 10 ++++ core/tabs/system-setup/tab_data.toml | 54 +++++++++++++++++-- .../ubuntu/hyprland-kool-ubuntu24.sh | 10 ++++ 6 files changed, 105 insertions(+), 16 deletions(-) create mode 100644 core/tabs/system-setup/arch/hyprland-kool.sh create mode 100644 core/tabs/system-setup/debian/hyprland-kool-deb.sh create mode 100644 core/tabs/system-setup/fedora/hyprland-kool-fed.sh create mode 100644 core/tabs/system-setup/ubuntu/hyprland-kool-ubuntu24.sh diff --git a/core/src/inner.rs b/core/src/inner.rs index a3a0fc9c..16d12cbe 100644 --- a/core/src/inner.rs +++ b/core/src/inner.rs @@ -111,12 +111,10 @@ fn default_true() -> bool { } #[derive(Deserialize)] +#[serde(rename_all = "snake_case")] enum EntryType { - #[serde(rename = "entries")] Entries(Vec), - #[serde(rename = "command")] Command(String), - #[serde(rename = "script")] Script(PathBuf), } @@ -132,14 +130,16 @@ impl Entry { match data { SystemDataType::Environment(var_name) => std::env::var(var_name) .is_ok_and(|var| values.contains(&var) == *matches), - SystemDataType::File(path) => { - std::fs::read_to_string(path).is_ok_and(|data| { - values.iter().all(|matching| data.contains(matching)) == *matches - }) - } + SystemDataType::ContainingFile(file) => std::fs::read_to_string(file) + .is_ok_and(|data| { + values + .iter() + .all(|matching| data.contains(matching) == *matches) + }), SystemDataType::CommandExists => values .iter() .all(|command| which::which(command).is_ok() == *matches), + SystemDataType::FileExists => values.iter().all(|p| Path::new(p).is_file()), } }, ) @@ -157,12 +157,11 @@ struct Precondition { } #[derive(Deserialize)] +#[serde(rename_all = "snake_case")] enum SystemDataType { - #[serde(rename = "environment")] Environment(String), - #[serde(rename = "file")] - File(PathBuf), - #[serde(rename = "command_exists")] + ContainingFile(PathBuf), + FileExists, CommandExists, } diff --git a/core/tabs/system-setup/arch/hyprland-kool.sh b/core/tabs/system-setup/arch/hyprland-kool.sh new file mode 100644 index 00000000..7c85f857 --- /dev/null +++ b/core/tabs/system-setup/arch/hyprland-kool.sh @@ -0,0 +1,15 @@ +#!/bin/sh + +. ../../common-script.sh + +printf "%b\n" "${YELLOW}Starting Hyprland JaKooLit installation${RC}" + +if ! pacman -Q base-devel >/dev/null 2>&1; then + printf "%b\n" "${YELLOW}Installing base-devel...${RC}" + "$ESCALATION_TOOL" pacman -S --noconfirm base-devel +fi + +git clone --depth=1 https://github.com/JaKooLit/Arch-Hyprland.git "$HOME/Arch-Hyprland" || { printf "%b\n" "${RED}Failed to clone Jakoolits Arch-Hyprland repo${RC}"; exit 1; } +cd "$HOME/Arch-Hyprland" || { printf "%b\n" "${RED}Failed to navigate to Arch-Hyprland directory${RC}"; exit 1; } +chmod +x install.sh +./install.sh diff --git a/core/tabs/system-setup/debian/hyprland-kool-deb.sh b/core/tabs/system-setup/debian/hyprland-kool-deb.sh new file mode 100644 index 00000000..58229792 --- /dev/null +++ b/core/tabs/system-setup/debian/hyprland-kool-deb.sh @@ -0,0 +1,9 @@ +#!/bin/sh + +. ../../common-script.sh + +printf "%b\n" "${YELLOW}Starting Hyprland JaKooLit installation${RC}" +git clone --depth=1 https://github.com/JaKooLit/Debian-Hyprland.git "$HOME/Debian-Hyprland" || { printf "%b\n" "${RED}Failed to clone Jakoolits Debian-Hyprland repo${RC}"; exit 1; } +cd "$HOME/Debian-Hyprland" || { printf "%b\n" "${RED}Failed to navigate to Debian-Hyprland directory${RC}"; exit 1; } +chmod +x install.sh +./install.sh \ No newline at end of file diff --git a/core/tabs/system-setup/fedora/hyprland-kool-fed.sh b/core/tabs/system-setup/fedora/hyprland-kool-fed.sh new file mode 100644 index 00000000..3a7ebd92 --- /dev/null +++ b/core/tabs/system-setup/fedora/hyprland-kool-fed.sh @@ -0,0 +1,10 @@ +#!/bin/sh + +. ../../common-script.sh + +printf "%b\n" "${YELLOW}Starting Hyprland JaKooLit installation${RC}" + +git clone --depth=1 https://github.com/JaKooLit/Fedora-Hyprland.git "$HOME/Fedora-Hyprland" || { printf "%b\n" "${RED}Failed to clone Jakoolits Fedora-Hyprland repo${RC}"; exit 1; } +cd "$HOME/Fedora-Hyprland" || { printf "%b\n" "${RED}Failed to navigate to Fedora-Hyprland directory${RC}"; exit 1; } +chmod +x install.sh +./install.sh \ No newline at end of file diff --git a/core/tabs/system-setup/tab_data.toml b/core/tabs/system-setup/tab_data.toml index 9f80eec0..51aa4745 100644 --- a/core/tabs/system-setup/tab_data.toml +++ b/core/tabs/system-setup/tab_data.toml @@ -16,15 +16,22 @@ task_list = "SI D" multi_select = false [[data.entries]] -name ="Linux Neptune for SteamDeck" +name = "Hyprland JaKooLit" +description = "Install JaKooLit's Hyprland configuration" +script = "arch/hyprland-kool.sh" +task_list = "I MP" +multi_select = false + +[[data.entries]] +name = "Linux Neptune for SteamDeck" description = "Valve's fork of Linux Kernel for the SteamDeck" script = "arch/linux-neptune.sh" task_list = "I PFM K" [[data.entries.preconditions]] matches = true -data = { file = "/sys/devices/virtual/dmi/id/board_vendor" } -values = [ "Valve" ] +data = { containing_file = "/sys/devices/virtual/dmi/id/board_vendor" } +values = ["Valve"] [[data.entries]] name = "Nvidia Drivers && Hardware Acceleration" @@ -50,6 +57,20 @@ description = "Yet Another Yogurt - An AUR Helper Written in Go. To know more ab script = "arch/yay-setup.sh" task_list = "I" +[[data]] +name = "Debian" + +[[data.preconditions]] +matches = true +data = { containing_file = "/etc/os-release" } +values = ["ID=debian"] + +[[data.entries]] +name = "Hyprland JaKooLit" +description = "Install JaKooLit's Hyprland configuration" +script = "debian/hyprland-kool-deb.sh" +task_list = "I MP" + [[data]] name = "Fedora" @@ -64,6 +85,12 @@ description = "Optimizes DNF for parallel downloads" script = "fedora/configure-dnf.sh" task_list = "PFM" +[[data.entries]] +name = "Hyprland JaKooLit" +description = "Install JaKooLit's Hyprland configuration" +script = "fedora/hyprland-kool-fed.sh" +task_list = "I MP" + [[data.entries]] name = "Multimedia Codecs" description = "This script is designed to install multimedia codecs, and to ensure RPM Fusion repositories are installed." @@ -103,7 +130,26 @@ task_list = "I PFM SS" [[data.preconditions]] matches = true data = "command_exists" -values = [ "btrfs" ] +values = ["btrfs"] + +[[data]] +name = "Ubuntu" + +[[data.preconditions]] +matches = true +data = { containing_file = "/etc/os-release" } +values = ["ID=ubuntu"] + +[[data.entries]] +name = "Hyprland JaKooLit" +description = "Install JaKooLit's Hyprland configuration" +script = "ubuntu/hyprland-kool-ubuntu24.sh" +task_list = "I MP" + +[[data.preconditions]] +matches = true +data = { containing_file = "/etc/os-release" } +values = ['VERSION_ID="24.04"'] [[data]] name = "Build Prerequisites" diff --git a/core/tabs/system-setup/ubuntu/hyprland-kool-ubuntu24.sh b/core/tabs/system-setup/ubuntu/hyprland-kool-ubuntu24.sh new file mode 100644 index 00000000..bd12ef76 --- /dev/null +++ b/core/tabs/system-setup/ubuntu/hyprland-kool-ubuntu24.sh @@ -0,0 +1,10 @@ +#!/bin/sh + +. ../../common-script.sh + +printf "%b\n" "${YELLOW}Starting Hyprland JaKooLit installation${RC}" + +git clone -b 24.04 --depth=1 https://github.com/JaKooLit/Ubuntu-Hyprland.git "$HOME/Ubuntu-Hyprland-24.04" || { printf "%b\n" "${RED}Failed to clone Jakoolits Ubuntu-Hyprland repo${RC}"; exit 1; } +cd "$HOME/Ubuntu-Hyprland-24.04" || { printf "%b\n" "${RED}Failed to navigate to Ubuntu-Hyprland-24.04 directory${RC}"; exit 1; } +chmod +x install.sh +./install.sh \ No newline at end of file From 6b572b1ab4de488f933c2c9fad280d2e9490f9d7 Mon Sep 17 00:00:00 2001 From: nyx Date: Tue, 11 Feb 2025 11:16:05 -0500 Subject: [PATCH 9/9] refactor: misc restructering (#1015) Changes: Separate cli flags and put them in their own module. Add a rustfmt configuration file for grouping imports into crates (so we dont have to do this manually, and it seems we were already doing it manually so might as well) Use comments to describe cli flags instead of using ugly syntax (they both work the same but one is less ugly and more readable) Add a --mouse flag to enable mouse interaction (mouse interaction is now off by default) Add a --bypass-root flag to disable the annoying popup when you run the utility as root Fix an issue where you can't reach the bottom of the list in a subdir (i also reduced the nesting in those functions as well for readability) Add help feature to clap dependency to enable --help / -h Add usage feature to clap dependency to enable usage example when running with --help / -h Remove CLI arg examples from readme, and add instructions on how to view them on CLI to prevent it from bloating up the readme --- README.md | 23 ++++++------------ core/src/inner.rs | 2 +- rustfmt.toml | 1 + tui/Cargo.toml | 2 +- tui/src/cli.rs | 35 +++++++++++++++++++++++++++ tui/src/main.rs | 38 +++++++---------------------- tui/src/root.rs | 8 ++++-- tui/src/state.rs | 59 +++++++++++++++++++++++++++++++++------------ xtask/src/docgen.rs | 3 +-- xtask/src/main.rs | 7 +++--- 10 files changed, 109 insertions(+), 69 deletions(-) create mode 100644 rustfmt.toml create mode 100644 tui/src/cli.rs diff --git a/README.md b/README.md index c0568171..a614f4bc 100644 --- a/README.md +++ b/README.md @@ -27,25 +27,18 @@ curl -fsSL https://christitus.com/linuxdev | sh ### CLI arguments -Linutil supports various command-line arguments to customize its behavior. Here are some common arguments you can use: - -- `-c, --config ` : Path to the configuration file. -- `--override-validation` : Show all available options, disregarding compatibility checks (UNSAFE). -- `--size-bypass` : Bypass the terminal size limit. -- `-y, --skip-confirmation` : Skip confirmation prompt before executing commands. -- `-t, --theme ` : Set the theme to use in the application [default: `default`] [possible values: `default`, `compatible`]. -- `-h, --help` : Print help. - -For more detailed usage, run: - -```bash -curl -fsSL https://christitus.com/linux | sh -s -- --help -``` +View available options by running: ```bash linutil --help ``` +For installer options: + +```bash +curl -fsSL https://christitus.com/linux | sh -s -- --help +``` + ## ⬇️ Installation Linutil is also available as a package in various repositories: @@ -142,7 +135,7 @@ Docs are now [here](https://github.com/Chris-Titus-Docs/linutil-docs) ## 🏅 Thanks to All Contributors -Thank you to everyone who has contributed to the development of Linutil. Your efforts are greatly appreciated, and you’re helping make this tool better for everyone! +Thank you to everyone who has contributed to the development of Linutil. Your efforts are greatly appreciated, and you're helping make this tool better for everyone! [![Contributors](https://contrib.rocks/image?repo=ChrisTitusTech/linutil)](https://github.com/ChrisTitusTech/linutil/graphs/contributors) diff --git a/core/src/inner.rs b/core/src/inner.rs index 16d12cbe..8621ea2b 100644 --- a/core/src/inner.rs +++ b/core/src/inner.rs @@ -120,7 +120,7 @@ enum EntryType { impl Entry { fn is_supported(&self) -> bool { - self.preconditions.as_deref().map_or(true, |preconditions| { + self.preconditions.as_deref().is_none_or(|preconditions| { preconditions.iter().all( |Precondition { matches, diff --git a/rustfmt.toml b/rustfmt.toml new file mode 100644 index 00000000..d9ba5fdb --- /dev/null +++ b/rustfmt.toml @@ -0,0 +1 @@ +imports_granularity = "Crate" \ No newline at end of file diff --git a/tui/Cargo.toml b/tui/Cargo.toml index 9143baf8..1041fc29 100644 --- a/tui/Cargo.toml +++ b/tui/Cargo.toml @@ -14,7 +14,7 @@ default = ["tips"] tips = ["rand"] [dependencies] -clap = { version = "4.5.20", features = ["derive", "std"], default-features = false } +clap = { version = "4.5.20", features = ["derive", "std", "help", "usage"], default-features = false } oneshot = { version = "0.1.8", features = ["std"], default-features = false } portable-pty = "0.8.1" ratatui = { version = "0.29.0", features = ["crossterm"], default-features = false } diff --git a/tui/src/cli.rs b/tui/src/cli.rs new file mode 100644 index 00000000..564b2d68 --- /dev/null +++ b/tui/src/cli.rs @@ -0,0 +1,35 @@ +use crate::theme::Theme; +use clap::Parser; +use std::path::PathBuf; + +#[derive(Debug, Parser, Clone)] +pub struct Args { + /// Path to the configuration file + #[arg(short, long)] + pub config: Option, + + /// Set the theme to use in the application + #[arg(short, long, value_enum)] + #[arg(default_value_t = Theme::Default)] + pub theme: Theme, + + /// Skip confirmation prompt before executing commands + #[arg(short = 'y', long)] + pub skip_confirmation: bool, + + /// Show all available options, disregarding compatibility checks (UNSAFE) + #[arg(short = 'u', long)] + pub override_validation: bool, + + /// Bypass the terminal size limit + #[arg(short = 's', long)] + pub size_bypass: bool, + + /// Enable mouse interaction + #[arg(short = 'm', long)] + pub mouse: bool, + + /// Bypass root user check + #[arg(short = 'r', long)] + pub bypass_root: bool, +} diff --git a/tui/src/main.rs b/tui/src/main.rs index 76ef584f..11ace649 100644 --- a/tui/src/main.rs +++ b/tui/src/main.rs @@ -1,3 +1,4 @@ +mod cli; mod confirmation; mod filter; mod float; @@ -11,7 +12,7 @@ mod theme; #[cfg(feature = "tips")] mod tips; -use crate::theme::Theme; +use crate::cli::Args; use clap::Parser; use ratatui::{ backend::CrosstermBackend, @@ -26,40 +27,17 @@ use ratatui::{ use state::AppState; use std::{ io::{stdout, Result, Stdout}, - path::PathBuf, time::Duration, }; -// Linux utility toolbox -#[derive(Debug, Parser)] -pub struct Args { - #[arg(short, long, help = "Path to the configuration file")] - config: Option, - #[arg(short, long, value_enum)] - #[arg(default_value_t = Theme::Default)] - #[arg(help = "Set the theme to use in the application")] - theme: Theme, - #[arg( - short = 'y', - long, - help = "Skip confirmation prompt before executing commands" - )] - skip_confirmation: bool, - #[arg(long, default_value_t = false)] - #[clap(help = "Show all available options, disregarding compatibility checks (UNSAFE)")] - override_validation: bool, - #[arg(long, default_value_t = false)] - #[clap(help = "Bypass the terminal size limit")] - size_bypass: bool, -} - fn main() -> Result<()> { let args = Args::parse(); - - let mut state = AppState::new(args); + let mut state = AppState::new(args.clone()); stdout().execute(EnterAlternateScreen)?; - stdout().execute(EnableMouseCapture)?; + if args.mouse { + stdout().execute(EnableMouseCapture)?; + } enable_raw_mode()?; let mut terminal = Terminal::new(CrosstermBackend::new(stdout()))?; @@ -70,7 +48,9 @@ fn main() -> Result<()> { // restore terminal disable_raw_mode()?; terminal.backend_mut().execute(LeaveAlternateScreen)?; - terminal.backend_mut().execute(DisableMouseCapture)?; + if args.mouse { + terminal.backend_mut().execute(DisableMouseCapture)?; + } terminal.backend_mut().execute(ResetColor)?; terminal.show_cursor()?; diff --git a/tui/src/root.rs b/tui/src/root.rs index 46432d06..23468ef2 100644 --- a/tui/src/root.rs +++ b/tui/src/root.rs @@ -8,8 +8,12 @@ This means you have full system access and commands can potentially damage your Please proceed with caution and make sure you understand what each script does before executing it."; #[cfg(unix)] -pub fn check_root_status<'a>() -> Option> { - (Uid::effective().is_root()).then_some(FloatingText::new( +pub fn check_root_status(bypass_root: bool) -> Option> { + if bypass_root { + return None; + } + + Uid::effective().is_root().then_some(FloatingText::new( ROOT_WARNING.into(), "Root User Warning", true, diff --git a/tui/src/state.rs b/tui/src/state.rs index 4bcb9c48..3baffef3 100644 --- a/tui/src/state.rs +++ b/tui/src/state.rs @@ -66,6 +66,7 @@ pub struct AppState { tip: &'static str, size_bypass: bool, skip_confirmation: bool, + mouse_enabled: bool, } pub enum Focus { @@ -94,8 +95,18 @@ enum SelectedItem { None, } +enum ScrollDir { + Up, + Down, +} + impl AppState { pub fn new(args: Args) -> Self { + #[cfg(unix)] + let root_warning = check_root_status(args.bypass_root); + #[cfg(not(unix))] + let root_warning = None; + let tabs = linutil_core::get_tabs(!args.override_validation); let root_id = tabs[0].tree.root().id(); @@ -122,10 +133,11 @@ impl AppState { tip: crate::tips::get_random_tip(), size_bypass: args.size_bypass, skip_confirmation: args.skip_confirmation, + mouse_enabled: args.mouse, }; #[cfg(unix)] - if let Some(root_warning) = check_root_status() { + if let Some(root_warning) = root_warning { state.spawn_float(root_warning, FLOAT_SIZE, FLOAT_SIZE); } @@ -440,6 +452,10 @@ impl AppState { } pub fn handle_mouse(&mut self, event: &MouseEvent) -> bool { + if !self.mouse_enabled { + return true; + } + if !self.drawable { return true; } @@ -597,24 +613,35 @@ impl AppState { true } - fn scroll_down(&mut self) { - if let Some(selected) = self.selection.selected() { - if selected == self.filter.item_list().len() - 1 { - self.selection.select_first(); - } else { - self.selection.select_next(); - } - } + fn scroll(&mut self, direction: ScrollDir) { + let Some(selected) = self.selection.selected() else { + return; + }; + let list_len = if !self.at_root() { + self.filter.item_list().len() + 1 + } else { + self.filter.item_list().len() + }; + + if list_len == 0 { + return; + }; + + let next_selection = match direction { + ScrollDir::Up if selected == 0 => list_len - 1, + ScrollDir::Down if selected >= list_len - 1 => 0, + ScrollDir::Up => selected - 1, + ScrollDir::Down => selected + 1, + }; + self.selection.select(Some(next_selection)); } fn scroll_up(&mut self) { - if let Some(selected) = self.selection.selected() { - if selected == 0 { - self.selection.select_last(); - } else { - self.selection.select_previous(); - } - } + self.scroll(ScrollDir::Up) + } + + fn scroll_down(&mut self) { + self.scroll(ScrollDir::Down) } fn toggle_multi_select(&mut self) { diff --git a/xtask/src/docgen.rs b/xtask/src/docgen.rs index 385c1134..15a5e2af 100644 --- a/xtask/src/docgen.rs +++ b/xtask/src/docgen.rs @@ -2,8 +2,7 @@ use std::fs; use linutil_core::Command; -use crate::path; -use crate::DynError; +use crate::{path, DynError}; pub const USER_GUIDE: &str = "userguide.md"; diff --git a/xtask/src/main.rs b/xtask/src/main.rs index fecab8c8..a1be3f7c 100644 --- a/xtask/src/main.rs +++ b/xtask/src/main.rs @@ -6,9 +6,10 @@ use std::{env, error::Error}; type DynError = Box; pub mod tasks { - use crate::docgen::USER_GUIDE; - use crate::docgen::{userguide, write}; - use crate::DynError; + use crate::{ + docgen::{userguide, write, USER_GUIDE}, + DynError, + }; pub fn docgen() -> Result<(), DynError> { write(USER_GUIDE, &userguide()?);